Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add meta option usage for pcs resource clone #648

Merged
merged 5 commits into from
Apr 18, 2023
Merged

add meta option usage for pcs resource clone #648

merged 5 commits into from
Apr 18, 2023

Conversation

F16shen
Copy link
Contributor

@F16shen F16shen commented Mar 1, 2023

fix https://bugzilla.redhat.com/show_bug.cgi?id=2168155
I'm not sure modify usage enough for this issue. The output looks like it adds meta properties for the clone, not the base resource. But to my understanding meta option is set for primitive resource

@knet-ci-bot
Copy link

Can one of the admins verify this patch?

tomjelinek
tomjelinek requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@tomjelinek tomjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage is correct, there is nothing to be fixed in there. What's wrong is parsing of pcs resource clone arguments. See comment 1 in the original bugzilla.

@F16shen F16shen force-pushed the description-meta-attribute-clone branch from b31bf9c to 8ff5e77 Compare March 28, 2023 09:54
@F16shen F16shen requested a review from tomjelinek April 6, 2023 07:19
@tomjelinek
Copy link
Member

test this please

tomjelinek
tomjelinek requested changes Apr 6, 2023
View reviewed changes
Copy link
Member

@tomjelinek tomjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the pull request. However, there are still issues which need to be resolved. Feel free to reach out to us if you need more guidance.

pcs/cli/resource/parse_args.py Outdated Show resolved Hide resolved
pcs/cli/resource/parse_args.py Outdated Show resolved Hide resolved
pcs/cli/resource/parse_args.py Outdated Show resolved Hide resolved
pcs/cli/resource/parse_args.py Outdated Show resolved Hide resolved
@F16shen F16shen force-pushed the description-meta-attribute-clone branch from 8ff5e77 to 2711721 Compare April 10, 2023 02:25
@F16shen
Copy link
Contributor Author

F16shen commented Apr 10, 2023

Thanks for the comments.
I only add a deprecated warning this time. Should I add tests as well?

@F16shen F16shen requested a review from tomjelinek April 10, 2023 02:31
@tomjelinek
Copy link
Member

test this please

@tomjelinek tomjelinek force-pushed the description-meta-attribute-clone branch from c3f09ce to 54dde37 Compare April 17, 2023 15:23
@tomjelinek
Copy link
Member

test this please

tomjelinek
tomjelinek approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@tomjelinek tomjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was it.

I just made sure that the deprecation warning doesn't get printed from pcs resource update command. And I updated tests and changelog, as there was not much to do.

@tomjelinek tomjelinek merged commit b93369e into ClusterLabs:main Apr 18, 2023
@F16shen F16shen deleted the description-meta-attribute-clone branch September 4, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjelinek tomjelinek tomjelinek approved these changes

@ondrejmular ondrejmular Awaiting requested review from ondrejmular

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@F16shen @knet-ci-bot @tomjelinek