booth: Check whether path '/etc/booth' exists #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
test this please |
|
retest this please |
Make tier0 tests independent on the real filesystem (which is a requirement for tier0 tests) and thus allow them testing both situations
|
Hi @daaitudian, thank you very much for the pull request. Excellent job finding your way through pcs code base! I did a few minor fixes and will merge the patch once it passes CI. |
|
test this please |
tomjelinek
approved these changes
Nov 25, 2021
|
Hi @tomjelinek ,Thank you so much for your help, especially those that I didn't notice. This has helped me a lot. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi:
I added a check before the error of opening the booth.key, which can be avoid the '/etc/booth/booth.key' error if the booth is not installed.
[booth] pcs booth setup shall not jump to report "No such file or directory: '/etc/booth/booth.key'" when /etc/booth doesn't exist #225