Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "find" should run only in specific directories #119

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Fix: "find" should run only in specific directories #119

merged 1 commit into from
Dec 6, 2016

Conversation

rafaeldtinoco
Copy link
Contributor

Some users reported that running find over "/var/lib" for cleanup
purposes can take too long depending on what you have installed.
A particular example was having "lxcfs" fuse mounted in /var/lib.
That can make the search for cluster leftovers to take quite some
time, making user to believe the process has hang.

Some users reported that running find over "/var/lib" for cleanup
purposes can take too long depending on what you have installed.
A particular example was having "lxcfs" fuse mounted in /var/lib.
That can make the search for cluster leftovers to take quite some
time, making user to believe the process has hang.
@rafaeldtinoco
Copy link
Contributor Author

This fix is coming specifically from:

https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640919

Meanwhile I'm also fixing bugs:

https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1580035
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1580045
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640923

If possible, could u please provide a fast answer if this commit can be accepted or not ? Tomorrow I'll propose upstream package fixes (Debian) to backport this to Ubuntu later on.

Thank you very much.

@tomjelinek tomjelinek merged commit c64ad9f into ClusterLabs:master Dec 6, 2016
@tomjelinek
Copy link
Member

Thanks for the patch!

@rafaeldtinoco
Copy link
Contributor Author

inaddy@(cluster01):~$ sudo pcs cluster destroy
Shutting down pacemaker/corosync services...
Killing any remaining services...
Removing all cluster configuration files...
find: ‘/var/lib/{pacemaker,corosync}’: No such file or directory
find: ‘/var/lib/{pacemaker,corosync}’: No such file or directory
find: ‘/var/lib/{pacemaker,corosync}’: No such file or directory
find: ‘/var/lib/{pacemaker,corosync}’: No such file or directory
find: ‘/var/lib/{pacemaker,corosync}’: No such file or directory
find: ‘/var/lib/{pacemaker,corosync}’: No such file or directory
find: ‘/var/lib/{pacemaker,corosync}’: No such file or directory

{} isn't interpreted in os.system(). My bad. Fixing it and proposing merge again.

@rafaeldtinoco
Copy link
Contributor Author

Please check #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants