-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doxygen2man: print structure descriptions #443
doxygen2man: print structure descriptions #443
Conversation
221da72
to
4ae6a6b
Compare
4ae6a6b
to
4ca865f
Compare
doxygen2man/cstring.c
Outdated
@@ -51,6 +51,19 @@ char *cstring_to_chars(cstring_t cstring) | |||
return strdup(h->the_string); | |||
} | |||
|
|||
size_t cstring_len(cstring_t cstring) | |||
{ | |||
struct cstring_header *h = (struct cstring_header *)(char *)cstring; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chrissie-c, why do you use these double casts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I can't remember now! I suspect it was to do with the compiler (or maybe covscan) complaining about alignment. I should check if they are still needed.
https://build.opensuse.org/request/show/931807 by user yan_gao + dimstar_suse - Update to version 2.0.4+20211112.a2691b9 (v2.0.4): - poll: Don't log in a signal handler (gh#ClusterLabs/libqb##447) - Fix pthread returns (gh#ClusterLabs/libqb#444) - doxygen2man: print structure descriptions (gh#ClusterLabs/libqb#443) - Implement heap based timer list (gh#ClusterLabs/libqb#439) (forwarded request 931806 from yan_gao)
The most important fix in this release is that we no longer log errors inside the signal handler in loop_poll.c This could cause an application hang in some circumstances. Changelog is as follows: doxygen2man: print structure descriptions (ClusterLabs/libqb#443) Fix pthread returns (ClusterLabs/libqb#444) poll: Don't log in a signal handler (ClusterLabs/libqb#447) Bump library version for v2.0.4 Implement heap based timer list (ClusterLabs/libqb#439) build: Fix undefined pthread reference. (ClusterLabs/libqb#440) Signed-off-by: Wang Mingyu <[email protected]> Signed-off-by: Khem Raj <[email protected]>
The most important fix in this release is that we no longer log errors inside the signal handler in loop_poll.c This could cause an application hang in some circumstances. Changelog is as follows: doxygen2man: print structure descriptions (ClusterLabs/libqb#443) Fix pthread returns (ClusterLabs/libqb#444) poll: Don't log in a signal handler (ClusterLabs/libqb#447) Bump library version for v2.0.4 Implement heap based timer list (ClusterLabs/libqb#439) build: Fix undefined pthread reference. (ClusterLabs/libqb#440) Signed-off-by: Wang Mingyu <[email protected]> Signed-off-by: Khem Raj <[email protected]>
The most important fix in this release is that we no longer log errors inside the signal handler in loop_poll.c This could cause an application hang in some circumstances. Changelog is as follows: doxygen2man: print structure descriptions (ClusterLabs/libqb#443) Fix pthread returns (ClusterLabs/libqb#444) poll: Don't log in a signal handler (ClusterLabs/libqb#447) Bump library version for v2.0.4 Implement heap based timer list (ClusterLabs/libqb#439) build: Fix undefined pthread reference. (ClusterLabs/libqb#440) Signed-off-by: Wang Mingyu <[email protected]> Signed-off-by: Khem Raj <[email protected]>
No description provided.