ipc: add qb_ipcc_auth_get() API call #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use SO_PEERCRED on the client fd when using socket IPC becayse it's a DGRAM socket (pacemaker tries this). So provide an API to get the server credentials that libqb has already squirreled away for its own purposes. Also, fix some unused-variable compiler warnings in unix.c when building on systems withpout posix_fallocate().
chrissie-c
changed the title
kgaillot
requested changes
Sep 24, 2020
lib/ipc_int.h
Outdated
| @@ -92,6 +92,7 @@ struct qb_ipcc_connection { | |||
| char name[NAME_MAX]; | |||
| int32_t needs_sock_for_poll; | |||
| gid_t egid; | |||
| uid_t euid; | |||
There was a problem hiding this comment.
I'd add this to the end of the struct so you don't have to bump the shared library version. Uglier, but library bumps are a hassle
lib/ipcc.c
Outdated
| } | ||
| *pid = c->server_pid; | ||
| *uid = c->euid; | ||
| *gid = c->egid; |
There was a problem hiding this comment.
For flexibility, I wouldn't require these to be non-NULL but wrap the assignments in if != NULL. That way callers can get just one or two values if that's all they need.
|
Update commit in the CI now. It's still failing covscan but those are stupid errors in the test suite so I'm happy to ignore them (they'll go in the ignore list for next time once it commited). I have the pacemaker patch to use this APi largely ready to go too. |
|
looks good to me |
kgaillot
approved these changes
Sep 25, 2020
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use SO_PEERCRED on the client fd when using socket IPC
becayse it's a DGRAM socket (pacemaker tries this). So provide
an API to get the server credentials that libqb has already
squirreled away for its own purposes.
Also, fix some unused-variable compiler warnings in unix.c
when building on systems withpout posix_fallocate().