Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add unit test for ipcs_connection_auth_set() #397

Merged
merged 1 commit into from
Jun 3, 2020
Merged

test: Add unit test for ipcs_connection_auth_set() #397

merged 1 commit into from
Jun 3, 2020

Conversation

chrissie-c
Copy link
Contributor

Only if we are root

@chrissie-c
Copy link
Contributor Author

retest this please

@chrissie-c
Copy link
Contributor Author

This is working on all platforms now. The coverity error is just covscan not understanding that fail_if() will abort the routine if the condition fails

jfriesse
jfriesse approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@jfriesse jfriesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really neat idea to have this part of code tested so ACK.

@chrissie-c
Copy link
Contributor Author

Thanks for the review.

@chrissie-c chrissie-c merged commit 08a165d into ClusterLabs:master Jun 3, 2020
@chrissie-c chrissie-c deleted the check_set_auth branch June 3, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfriesse jfriesse jfriesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrissie-c @jfriesse