Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxygen2man #388

Merged
merged 5 commits into from
Mar 18, 2020
Merged

Doxygen2man #388

merged 5 commits into from
Mar 18, 2020

Conversation

fabbione
Copy link
Member

No description provided.

chrissie-c and others added 5 commits March 12, 2020 13:20
This is in here from kronosnet so it cna be used by other parts
of the cluster stack.
Signed-off-by: Fabio M. Di Nitto <[email protected]>
Signed-off-by: Fabio M. Di Nitto <[email protected]>
Signed-off-by: Fabio M. Di Nitto <[email protected]>
@fabbione
Copy link
Member Author

@wferi I have been talking with @chrissie-c on IRC and here is the summary:

the current build system allows to do normal and cross-compile build as-is.

Once the man pages for libqb will be auto-generated by doxygen2man, people doing normal builds will not notice any difference.

People performing cross-compilation have 2 options:

  • do a normal build and install on the system and then do the cross-build to get the man pages generated automatically
  • do a cross build and man pages are not generated.

This way we limit the 2 phase bootstrap of libqb only for people doing cross-compilation, that is a minority of the use base, without creating extreme complexity for people doing normal builds.

The infra is in place, just need to extend as we kill hardcoded man pages.

Copy link
Contributor

@chrissie-c chrissie-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I think it's ready to go in now.
ACK

@fabbione fabbione merged commit 93f9975 into master Mar 18, 2020
@BtbN
Copy link

BtbN commented Jul 13, 2020

Should this really be installed along with the library though? Seems a bit out of place for libqb to install a doxygen-related tool.

@kgaillot
Copy link
Contributor

Should this really be installed along with the library though? Seems a bit out of place for libqb to install a doxygen-related tool.

See the discussion on #387 which led to this one

@wenningerk
Copy link

And that it is part of the libqb-repo doesn't necessarily mean you would have to package it together with the library so that it would be installed on every production cluster.

@chrissie-c chrissie-c deleted the doxygen2man branch July 15, 2020 07:07
@chrissie-c
Copy link
Contributor

In Fedora, it has its own package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants