Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blackbox-segfault test - remove residual core files #315

Closed
wants to merge 1 commit into from
Closed

blackbox-segfault test - remove residual core files #315

wants to merge 1 commit into from

Conversation

grooverdan
Copy link
Contributor

travis test failures on disttest showed corefiles left over. May as well remove them in the blackbox-segfault test.

@knet-ci-bot
Copy link

Can one of the admins verify this patch?

@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 24, 2018

ok to test

@fabbione
Copy link
Member

ok to test

@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 24, 2018

Ah, I remember now!
#237 (comment)

Anyway, if the immediately preceding qb-blackbox run was what caused
the coredump at hand to be generated, your patch is not expected to
help since there's:

[ $? -gt 127 ] && exit 1 || true

and unless either the libtool's wrapper over the actual compiled binary
or the executing shell, assuming POSIX compatibility[*1], is botched,
the script will return earlier than where you put your clean command.

[*1]
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_08_02:

The exit status of a command that terminated because it received
a signal shall be reported as greater than 128.

So the best solution appears to turn that AND-OR list into
properly conditionalized block where in the segfault case you
first run a command to print out the backtrace into stderr[*2],
then remove the core, then run exit 1.

[*2] see, e.g.,
https://github.com/jnpkrn/clufter/blob/v0.77.1/.travis.yml#L78-L82

@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 24, 2018

Not to forget, thank you so much for pointing out this fishiness
with Travis CI!

@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 26, 2018

Hmm, I start to see where this comes from.

Please, do the core removal right after

  3 # create a normal blackbox
  4 rm -f crash-test-dummy.fdata
  5 ./crash_test_dummy

where it belongs instead.

@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 28, 2018

Pushed by hand (didn't trigger autoclose).
Thanks!

@jnpkrn jnpkrn closed this Aug 28, 2018
@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 28, 2018

621b743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants