tests: use RUNPATH instead of RPATH consistently #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some vendors default to RPATH, others to RUNPATH. The former does not allow override with LD_LIBRARY_PATH when running binaries such as test suite and it was causing problems on platforms where RPATH is default, by running the test suite against the wrong library (out-of-tree vs in-tree). This change has no effect on libqb itself, but only on the binaries. Signed-off-by: Fabio M. Di Nitto <[email protected]>
jnpkrn
added a commit
to jnpkrn/libqb
that referenced
this pull request
Sep 14, 2018
…#309)" This reverts commit eeb5e45. Said change did not undergo standard review and seems superfluous, since we inject neither RPATH nor RUNPATH into the resulting shared library, therefore it's questionable why we should be carrying this burden and influence anything by force. Redistributors are free to make their own choices. If that requires assistance on libqb's side their _conditional_ patches are welcome. Signed-off-by: Jan Pokorný <[email protected]>
jnpkrn
added a commit
to jnpkrn/libqb
that referenced
this pull request
Sep 14, 2018
…#309)" This reverts commit eeb5e45. Said change did not undergo standard review and seems superfluous, since we inject neither RPATH nor RUNPATH into the resulting shared library, therefore it's questionable why we should be carrying this burden and influence anything by force. Redistributors are free to make their own choices. If that requires assistance on libqb's side, their _conditional_ patches are welcome. Signed-off-by: Jan Pokorný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some vendors default to RPATH, others to RUNPATH. The former does not allow override
with LD_LIBRARY_PATH when running binaries such as test suite and it was causing
problems on platforms where RPATH is default, by running the test suite against
the wrong library (out-of-tree vs in-tree).
This change has no effect on libqb itself, but only on the binaries.
Signed-off-by: Fabio M. Di Nitto [email protected]