tests: Improve test isolation #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make all the IPC tests run with a common date/pid stamp name, so that the final resource.test only fails if it finds one of OUR files lefti lying around and not those from another test. Signed-off-by: Christine Caulfield <[email protected]>
jfriesse
reviewed
Mar 6, 2018
tests/check_ipc.c
Outdated
|
|
||
| /* The process-unique part of the IPC name has already been decided | ||
| * and stored in the file ipc-test-name. | ||
| */ |
There was a problem hiding this comment.
It may be nice to have some fallback when ipc-test-name file does not exists because right now, result is going to be random bytes from memory.
| # The test programs all add "qb-test-<name>-" to the front of this. | ||
| # | ||
| NAME="$$-`date +%N`" | ||
| echo -n "$NAME" > ipc-test-name |
|
Perfect, looks good now (and ci passed :) ), so ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all the IPC tests run with a common date/pid stamp name, so that
the final resource.test only fails if it finds one of OUR files left
lying around and not those from another test.
Signed-off-by: Christine Caulfield [email protected]