Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require c99 language support or newer #251

Merged
merged 1 commit into from
May 18, 2017
Merged

Require c99 language support or newer #251

merged 1 commit into from
May 18, 2017

Conversation

jonesmz
Copy link
Contributor

@jonesmz jonesmz commented May 17, 2017

Note also that gcc 5.4.0 and later default to the gnu11 version of the C11 standard.

@jnpkrn
Copy link
Contributor

jnpkrn commented May 18, 2017

Good point. I think we are shooting for C99 at minimum.

@chrissie-c chrissie-c merged commit a95b81b into ClusterLabs:master May 18, 2017
@chrissie-c
Copy link
Contributor

yes, good idea. Thanks!

@jnpkrn
Copy link
Contributor

jnpkrn commented May 18, 2017

@jonesmz Perhaps one point for the future: it would be strongly preferred
if you could have your account (or workflow -- have you edited on-the-fly
via GitHub interface?) associated with proper email address, for some kind
of persistent/reliable mapping of your libqb contributions to your persona.

At least @users.noreply.github.com intermediary type of contact does not
fit that definition in my book, however I look at it.

@jnpkrn
Copy link
Contributor

jnpkrn commented May 18, 2017

@jonesmz Sorry, it must be some new misfeature of GitHub, I can observe
the same at my own recent contribution as well!

@jnpkrn
Copy link
Contributor

jnpkrn commented May 18, 2017

Actually, it was due to the change of project settings.
My proposal is to resort to manual handling of the PRs going forward.
It's a matter of two git commands or so, after all.

Web interface machinery for PR handling is overboard intrusive.

@jonesmz
Copy link
Contributor Author

jonesmz commented May 18, 2017

@jnpkrn

Sorry, no, not interested in changing that setting. I actually have my "real" email set up for my git command line interface, but only because "jonesmz@randomcomputername" was silly.

Now that I know github is auto-hiding it, I much prefer not revealing my personal email to the world perpetually. I get enough spam as it is.

Contrasted against you ([email protected] , correct?), I am not paid to work on open source by my employer, so I have no incentive to continue participating perpetually.

@jonesmz jonesmz deleted the c99 branch May 18, 2017 16:00
@jnpkrn
Copy link
Contributor

jnpkrn commented May 18, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants