log: enum qb_log_target_slot introduction + qblog.h cleanup #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amongst other uses, this allows for better (fixed) documentation regarding how many additional logging targets the user can define.
Also use the new enum qb_log_target_slot type in for-loops together with a proper substitute for the literal "0" initializer. There could be more places that might be type-substituted for this enum (and hence possibly catch more of an incorrect usage if the compiler or checker has some notion of enum type narrowing), but leave it as a possible enhancement for now.
jnpkrn
force-pushed
the
log-target-slot-enum
branch
from
328495d to
595c8a2
Compare
jnpkrn
changed the title
jnpkrn
force-pushed
the
log-target-slot-enum
branch
from
595c8a2 to
3496fcf
Compare
Also add missing "stdout" to the enumerations of the static ones.
It doesn't matter that also syslog is disabled first, as it will get enabled few lines later on (uniformity + simplicity > optimization + complexity).
- use semicolons at the end of the description - use commas when there can be an issue with parsing a long sentence (and wrap such text at 79 characters if applicable)
jnpkrn
force-pushed
the
log-target-slot-enum
branch
from
3496fcf to
837108b
Compare
chrissie-c
added a commit
that referenced
this pull request
Feb 22, 2016
log: enum qb_log_target_slot introduction + qblog.h cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.