pgsqlms: only check notify and promotable when OCF_CHECK_LEVEL=10 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalbrigt
force-pushed
the
pgsqlms-validate-all-ocf_check_level-10
branch
from
c85bee8
to
a5e1c41
Compare
|
Hi, Just for the record, this is currently discussed on the pacemaker mailing list.
This is not a Pacemaker change. It is a pcs one and there might be a possible fix there about setting meta parameters during the Moreover, another non pcs-related fix might be to exec some of these checks to the probe action. I'll update here. Thank you! |
Pacemaker has started running validate-all action before creating the resource. It doesnt provide notify/promotable settings while doing so, so this patch moves these checks to OCF_CHECK_LEVEL 10 and runs the validate action at OCF_CHECK_LEVEL 10 when action is not validate-all.
oalbrigt
force-pushed
the
pgsqlms-validate-all-ocf_check_level-10
branch
from
a5e1c41
to
8986161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pacemaker has started running validate-all action before creating the resource. It doesnt provide notify/promotable settings while doing so, so this patch moves these checks to OCF_CHECK_LEVEL 10 and runs the validate action at OCF_CHECK_LEVEL 10 when action is not validate-all.