Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send video in smart replies work on KiboChat #66

Open
sojharo opened this issue Nov 6, 2018 · 3 comments
Open

Send video in smart replies work on KiboChat #66

sojharo opened this issue Nov 6, 2018 · 3 comments
Assignees
@ImranBinShoukat
Labels
code complete High Resolved

Comments

@sojharo
Copy link
Collaborator

sojharo commented Nov 6, 2018

We have recently did some updates on KiboPush staging for smart replies for upcoming demo. In this, Imran has made the smart replies changes to support Youtube video play in the messenger. We need to move the similar logic to KiboChat as well so that this change becomes part of the restructure work as well.
@sojharo
Copy link
Collaborator Author

sojharo commented Nov 7, 2018

@ImranBinShoukat Sir wanted to discuss that should this not be part of KiboEngage. I think this youtube video according to sir should be done in broadcast as well. I think you have only done it in smart replies? Let's discuss this when you get well and come.

@ImranBinShoukat
Copy link
Collaborator

Yes this work will be done on KiboEngage as well (in broadcasts). I'll open an issue for that.

@ImranBinShoukat ImranBinShoukat self-assigned this Nov 9, 2018
ImranBinShoukat pushed a commit that referenced this issue Nov 10, 2018
send video #66
df62753
@ImranBinShoukat ImranBinShoukat mentioned this issue Nov 10, 2018
Merged
@ImranBinShoukat
Copy link
Collaborator

Work on this task has been completed. Assigning @bjafri5 to test this.

@jekram jekram added the High label Nov 14, 2018
@bjafri5 bjafri5 removed their assignment Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ImranBinShoukat ImranBinShoukat

Labels
code complete High Resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jekram @sojharo @ImranBinShoukat @bjafri5