Add horizontal alignment and improve center alignment #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-M or --margin option sets the horizontal margin of the window
single enum determines if the menu is at the top, in the center, or at the bottom. implemented in wayland and x11 renderers.
|
Thanks, one thing I'm starting to be concerned is the pollution of single character options, we may want to keep advanced options as a long options only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--marginoption which can be used to set the empty space on the left and right of the menu. Also makes the behavior of--centermore predictable and work on both x11 and wayland. Related to the discussion in #194.