Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the default task setup back to the initial setup #1534

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented Oct 20, 2024

Motivation

After the removal of CloudPerms the initial setup did not contain the default task setup for Lobby and Proxy anymore because it only relied on the fact that the task provider was initialized before the setup was started. The removal of CloudPerms also removed that early init and thus the setup was not complete anymore.

Modification

Added the task provider as parameter to the setup step of the node. Aerogel is forced to init the provider first and therefore the setup is registered before the actual start of the setup.

Result

The default task setup is back.

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code t: fix A pull request introducing a fix for a bug. labels Oct 20, 2024
@0utplay 0utplay added this to the 4.0.0-RC11.1 milestone Oct 20, 2024
@0utplay 0utplay requested a review from derklaro October 20, 2024 13:11
@0utplay 0utplay self-assigned this Oct 20, 2024
Copy link

Test Results

 48 files  ±0   48 suites  ±0   1m 56s ⏱️ +4s
420 tests ±0  420 ✅ ±0  0 💤 ±0  0 ❌ ±0 
751 runs  ±0  751 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cdcc921. ± Comparison against base commit 93cdaf4.

This pull request removes 37 and adds 37 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","this":"is","insane":"!"}}, PRETTY
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-10-18
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 17:49:17.137256662
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 17:49:17.137425975Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 17:49:17.137456602Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 17:49:17.137479354+05:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 17:49:17.137498650-03:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-10-18T17:49:17.137517445
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-10-18T17:49:17.137627910Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-10-18T17:49:17.137132561Z
…
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","hello":"world","insane":"!"}}, PRETTY
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-10-21
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 07:56:20.809792385
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 07:56:20.809948656Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 07:56:20.809975807Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 07:56:20.809998950+05:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 07:56:20.810024648-03:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-10-21T07:56:20.810045206
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-10-21T07:56:20.810173335Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-10-21T07:56:20.809677511Z
…

@derklaro derklaro merged commit 4370add into nightly Oct 21, 2024
6 checks passed
@derklaro derklaro deleted the fix/task-setup-missing-in-initial-setup branch October 21, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: node An issue/pull request releated to the node module code t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants