Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #13: Updated runner.js to get files with a glob #14

Merged
merged 2 commits into from
Oct 18, 2020
Merged

Fixes #13: Updated runner.js to get files with a glob #14

merged 2 commits into from
Oct 18, 2020

Conversation

shivansh1010
Copy link
Contributor

@shivansh1010 shivansh1010 commented Oct 17, 2020 •
edited
Loading

#13 Changed getFilesRecursive() in runner.js to get the files with a glob

Please take a look and tell me if it's alright. If it's ok, then please add hacktoberfest-accepted label.

NJKode
NJKode suggested changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@NJKode NJKode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One small change though: We are no longer doing this recursively, so change getFilesRecursive to just getFiles (along with the references to this function).

@NJKode NJKode linked an issue Oct 18, 2020 that may be closed by this pull request
Change getFilesRecursive() in runner.js to get the files with a glob #13
Closed
@shivansh1010 shivansh1010 requested a review from NJKode October 18, 2020 05:44
@NJKode NJKode added enhancement New feature or request hacktoberfest-accepted labels Oct 18, 2020
NJKode
NJKode approved these changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@NJKode NJKode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@NJKode NJKode merged commit b947d34 into CloudCannon:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NJKode NJKode NJKode approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change getFilesRecursive() in runner.js to get the files with a glob
2 participants
@shivansh1010 @NJKode