add kube version #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ locals { | |||
| #Enable this to provision VPC cluster. | |||
| create_cluster = true | |||
| #True to create new Observability Services. False if Observability Service instances are already existing. | |||
| enable_observability = true | |||
| enable_observability = false | |||
There was a problem hiding this comment.
create the same enable_observability variable in the variables file and use it instead of this local var in main.if
(use var.enable_observability instead of local.enable_observability)
| @@ -41,6 +41,12 @@ variable "tags" { | |||
| # } | |||
| } | |||
|
|
|||
| variable "kube_version" { | |||
| description = "Kubernetes version" | |||
| default = "4.9.21_openshift" | |||
There was a problem hiding this comment.
pls check the latest iks/openshift version and use it as default for now
There was a problem hiding this comment.
Can we move this also to v ariables files where user can provide value.
If we keep some default value after few days the version will be unsupported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.