Do not override built-in config location in keymaster.service. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Debian setcap is in /sbin rather than /usr/sbin, so startup fails.
cviecco
reviewed
Jan 22, 2020
Contrary to the documentation and what's shown by "systemd-path search-binaries", systemd on CentOS does not do PATH lookup for ExecStart*= commands. It works as advertised on Debian.
|
Tested now. Indeed, CentOS is broken, because it doesn't do PATH lookup even though the documentation says it does. Latest commit fixes it. |
ph4r05
added a commit
to ph4r05/keymaster
that referenced
this pull request
Jun 12, 2024
* add flavour, version command, fix version source (Cloud-Foundations#229) - make makefile single source of truth for version - trigger the flow in the tests * minor tests enhancements (Cloud-Foundations#232) * Docker cleanup (Cloud-Foundations#233) * Removed unnecessary `start.sh` * Updated Dockerfile to newer OS * Cleaned up Dockerfile dirty hack for RSA keys Co-authored-by: Espinoza, Erik <[email protected]> * enable to specify agent connection to insert cert to (Cloud-Foundations#231) * enable to specify agent connection to insert cert to * add api * bump version --------- Co-authored-by: Dušan Klinec <[email protected]> --------- Co-authored-by: Dušan Klinec <[email protected]> Co-authored-by: cviecco <[email protected]> Co-authored-by: Erik Espinoza <[email protected]> Co-authored-by: Espinoza, Erik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the build-in default for the
-configoption and the output of-generateConfighave/etc/keymaster/config.ymlas the configuration file. It's just confusing for the system service file to change that.