fix: Addded logger and prompt updates

Cloud-Code-AI · Apr 1, 2024 · 1118bdf · 1118bdf
1 parent 43787de
commit 1118bdf
Show file tree

Hide file tree

Showing 8 changed files with 143 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -159,4 +159,5 @@ cython_debug/
 #  option (not recommended) you can uncomment the following to ignore the entire idea folder.
 #.idea/
 
-.env
+.env
+*.pem
diff --git a/api/github_helper/endpoints.py b/api/github_helper/endpoints.py
@@ -6,6 +6,6 @@
 GITHUB_ENDPOINTS = {
     "get_installations": urljoin(GITHUB_API_BASE_URL, "installations"),
     "get_installation_access_token": urljoin(
-        GITHUB_API_BASE_URL, "installations/{installation_id}/access_tokens"
+        GITHUB_API_BASE_URL, "/app/installations/{installation_id}/access_tokens"
     ),
 }
diff --git a/api/github_helper/installation.py b/api/github_helper/installation.py
@@ -5,6 +5,7 @@
 
 def get_installations():
     headers = utils.HEADERS
+    headers["Authorization"] = f"Bearer {utils.generate_jwt()}"
     url = GITHUB_ENDPOINTS["get_installations"]
     response = requests.get(url, headers=headers)
     response.raise_for_status()

diff --git a/api/github_helper/utils.py b/api/github_helper/utils.py
@@ -8,7 +8,7 @@
 GITHUB_APP_WEBHOOK_SECRET = os.environ.get("GITHUB_APP_WEBHOOK_SECRET")
 
 
-HEADER = {
+HEADERS = {
     "Authorization": None,
     "Accept": "application/vnd.github.v3+json",
     "X-GitHub-Api-Version": "2022-11-28",
@@ -26,7 +26,7 @@ def generate_jwt():
         "exp": expiration_time,
         "iss": GITHUB_APP_ID
     }
-    with open(".key.pem", "r") as f:
+    with open("GITHUB_APP_KEY.pem", "r") as f:
         # Encode the JWT using the RS256 algorithm
         encoded_jwt = jwt.encode(payload, f.read(), algorithm="RS256")
     return encoded_jwt

diff --git a/codecheck/actions/reviews.py b/codecheck/actions/reviews.py
@@ -2,6 +2,9 @@
 from codecheck.llms.provider import chat_completion
 from codecheck.llms.prompts import CODE_REVIEW_PROMPT, CODE_REVIEW_SYSTEM_PROMPT
 import requests
+import logging
+
+logger = logging.getLogger(__name__)
 
 
 def review_pull_request(
@@ -39,4 +42,4 @@ def post_pull_request(url, data, access_token):
         "Accept": "application/vnd.github.v3+json",
     }
     response = requests.post(url, headers=headers, json=data)
-    print("Post Pull request response: ", response.text)
+    logger.info(f"Post Pull request response: {response.text}")
diff --git a/codecheck/llms/prompts.py b/codecheck/llms/prompts.py
@@ -51,4 +51,6 @@
 8. **General Feedback**: Provide overall feedback on the code changes, highlighting strengths and areas for improvement.
 
 Your code review should be thorough, constructive, and actionable, helping the developer understand your concerns and recommendations clearly. Point to the code while suggesting changes.
+
+Respond as a json with the feedback in a list; example: {{"review": {{"Testing missing": ["details"], "Security Vulnerability": ["details"]}} }}
 """
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -15,6 +15,7 @@ fastapi = "^0.110.0"
 litellm = "^1.34.18"
 flake8 = "^7.0.0"
 black = "^24.3.0"
+cryptography = "^42.0.5"
 
 
 [build-system]