Fix ActiveSupport 5.1 deprecation warnings #262
Conversation
|
Oddly, the failures that are showing up under Travis for the edge appraisal are not the same ones that I'm getting on my machine. But they're too tough for me to parse, and there's no deprecation warnings (other than those coming out of |
| @@ -35,10 +35,13 @@ def _ct_before_save | |||
| end | |||
|
|
|||
| def _ct_after_save | |||
| if changes[_ct.parent_column_name] || @was_new_record | |||
| as_5_1 = ActiveSupport.version >= Gem::Version.new('5.1.0') | |||
| changes_method = as_5_1 ? :saved_changes : :changes | |||
There was a problem hiding this comment.
Wow, that's pretty horrible that Rails is making us do this. Bummer.
I can't think of a more elegant way to do it though. Thanks for this PR.
There was a problem hiding this comment.
Maybe this is a little less ugly?
changes_method = respond_to?(:saved_changes) ? :saved_changes : :changes
There was a problem hiding this comment.
Yeah, maybe? I guess I'm just frustrated by the rails team for making changes like this. Over and over again. If you think the other way is better, I'll merge your PR.
There was a problem hiding this comment.
I'm just frustrated by the rails team for making changes like this.
For the record, this change was not "oh this is better this way". The change in behavior of these methods was required to fix dozens of bugs, and significantly simplify the implementation of associations (weeding out even more bugs). It's not something that was taken lightly.
There was a problem hiding this comment.
@sgrif not meant as a personal affront--just a recognition of seven years of API churn.
There was a problem hiding this comment.
For sure. There have been a lot of needless changes that hurt gems over the years.
Notably, there are still 4 test failures on ActiveRecord-edge, having to do with the "chained activerecord association subroot" tests. Debugging those is beyond my level of acquaintance with the code base. But the deprecation warnings surrounding
attribute_changed?,attribute_was, andchangeshave all been silenced here.