Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance compatibility for SqlServer 2008 #200

Merged
merged 2 commits into from
Oct 10, 2016

Conversation

MartinKoerner
Copy link
Contributor

The code contains several statements like "GROUP BY 1". This is not supported in MS SQL, but can easily rewritten to "GROUP BY ascendent_id", which works for all SQL implementations.

@seuros
Copy link
Member

seuros commented Feb 10, 2016

We will need a benchmark with Postgresql and MYSQL. MSSql is not supported officially.

@MartinKoerner
Copy link
Contributor Author

Do you have a preferred one?

I compared spec runs on my local laptop with this gist: https://gist.github.com/MartinKoerner/20f57509a2b3cebc5d69,
but it deviated around 4sec even without any change and me not touching the laptop, so it is not helpful for this small level problem.

@mceachen
Copy link
Collaborator

mceachen commented Feb 12, 2016 via email

@mceachen
Copy link
Collaborator

mceachen commented Oct 9, 2016

This is innocuous to merge.

@mceachen mceachen merged commit 6a30536 into ClosureTree:master Oct 10, 2016
@MartinKoerner MartinKoerner deleted the group_by_for_mssql branch October 28, 2016 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants