Strong Parameters and Rails 3

[leonelgalan]

After setting config.whitelist_attributes = false in application.rb, the model that is acting as a tree raises ActiveModel::MassAssignmentSecurity::Error. This is, because closure_tree is adding attr_accessible :parent (https://github.com/mceachen/closure_tree/blob/32da850126336fec6036ad8154a9b1fa738cb30e/lib/closure_tree/model.rb#L17)

https://github.com/mceachen/closure_tree/blob/32da850126336fec6036ad8154a9b1fa738cb30e/lib/closure_tree/support.rb#L23

    def use_attr_accessible?
      ActiveRecord::VERSION::MAJOR == 3 &&
        defined?(ActiveModel::MassAssignmentSecurity) &&
        model_class.ancestors.include?(ActiveModel::MassAssignmentSecurity)
    end

I beleive that this happens because of the last condition of use_attr_accessible?, which returns true even when using strong parameters. A better condition will be model_class.accessible_attributes.empty?, which returns true only when attr_accessible has been used in the model.

[mceachen]

https://travis-ci.org/mceachen/closure_tree/builds/7831942 is building e72b0a1 which has your suggestion. Thanks!

[leonelgalan]

Thanks for trying, based on the failed builds (4 is passing because of the frist condition), I just noticed I missed a ! (NOT) before the suggested condition. If it's not empty, it means the user is already using attr_accessible with some fields and its safe to use it in closure_tree.

[mceachen]

OK—we'll see how 4379712 goes.

[mceachen]

HURRAY https://travis-ci.org/mceachen/closure_tree/builds/7897320 I'll get this into the next version that I'm about to release.

[samnang]

@mceachen I'm still getting an issue that @leonelgalan described above in my rails 3 app that is using strong parameter:

>> CaseType.accessible_attributes.nil?
=> false
>> CaseType.accessible_attributes
=> #<ActiveModel::MassAssignmentSecurity::WhiteList: {}>
>> CaseType.accessible_attributes.empty?
=> true

So I think the correct way it should check for empty instead of checking nil.

[doxavore]

I'm seeing the same thing as @samnang in Rails 3.2.18 with strong_parameters enabled. Patching https://github.com/mceachen/closure_tree/blob/ff8331eca84300330aad6455837d3872bd9ce519/lib/closure_tree/support_flags.rb#L7 to use .empty? instead of .nil? fixed it for me as well.

[mceachen]

Ok, I'll try to get that into master soon. Thanks for the comment.
On Jun 4, 2014 6:28 PM, "Doug Mayer" [email protected] wrote:

I'm seeing the same thing as @samnang https://github.com/samnang in
Rails 3.2.18 with strong_parameters enabled. Patching
https://github.com/mceachen/closure_tree/blob/ff8331eca84300330aad6455837d3872bd9ce519/lib/closure_tree/support_flags.rb#L7
to use .empty? instead of .nil? fixed it for me as well.

—
Reply to this email directly or view it on GitHub
#60 (comment)
.

[mceachen]

ok, it's in v4.6.1. Thanks!