Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging over a bubble card triggers a popup #839

Open
michaelarnauts opened this issue Oct 6, 2024 · 16 comments
Open

Dragging over a bubble card triggers a popup #839

michaelarnauts opened this issue Oct 6, 2024 · 16 comments
Labels
bug Something isn't working

Comments

@michaelarnauts
Copy link

Describe the bug
When dragging over a button card (to scroll down), a popup is triggered.

Also, when using swipe navigation, the same happens when scrolling left/right to navigate to a different tab.

To Reproduce
Steps to reproduce the behavior:

  1. Add a few bubble cards to a dashboard
  2. Drag down to scroll (on mobile)
  3. A popup is triggered of the bubble card where dragging was initiated.

Expected behavior
Just scroll down without triggering a popup.

Screenshots
If applicable, add screenshots to help explain your problem.

YAML
If applicable, add any relevant YAML code.

Your code here

Informations (please complete the following information):

  • OS: Android
  • Browser/App: Official HA app
  • Bubble Card version: 2.3.0 beta 2
  • Home Assistant version: 2024.10.1

Additional context
Add any other context about the problem here.

Thank you! 🍻

@michaelarnauts michaelarnauts added the bug Something isn't working label Oct 6, 2024
@FalkPe
Copy link

FalkPe commented Oct 8, 2024

I have the same problem

@Clooos
Copy link
Owner

Clooos commented Oct 8, 2024

Hi! I'm already on it! It will be perfect in the next beta 👌

@Tee86
Copy link

Tee86 commented Oct 12, 2024

@Clooos , not sure if this info helps you, but I don't have this issue at all and the config is the same:
OS: Android
Browser/App: Official HA app
Bubble Card version: 2.3.0 beta 2
Home Assistant version: 2024.10.1

Nor my client who uses iOs app reported this behaviour.
Looks like a specific conflict issue with other integration that I don't have installed on my server.

@Clooos
Copy link
Owner

Clooos commented Oct 12, 2024

This issue is already fixed, I just need a bit more time for releasing the new beta.

@michaelarnauts
Copy link
Author

@Clooos could you already commit the fix to the main branch? I could use the latest main in HACS then while waiting for a release.

@Clooos
Copy link
Owner

Clooos commented Oct 12, 2024

Done 👌

@michaelarnauts
Copy link
Author

Unfortunately, it still has an issue, when scrolling down, but the viewport is already at the bottom (or scrolling up at the top), the click is still triggered.

A click is also triggered when scrolling to the side (when using swipe navigation to switch to the next tab).

@peterthepeter
Copy link

Hello,

Unfortunately I still have the problem with Bubble Card v2.3.0-beta.3

on my iPhone with Safari or Arc.
iOS 18.0.1

Best regards
Christian

@sebster6
Copy link

sebster6 commented Nov 7, 2024

Same issue on beta 4 as well :(

iOS 18.1
Home Assistant Companion App 2024.9.4
Home Assistant 2024.10.3

@Clooos
Copy link
Owner

Clooos commented Nov 7, 2024

Hi! This issue should be definitely fixed in the next release, I've added a new system that disable all actions when a scroll is detected. This time it should perfect 🤞

@michaelarnauts
Copy link
Author

Hi! This issue should be definitely fixed in the next release, I've added a new system that disable all actions when a scroll is detected. This time it should perfect 🤞

There still is the case where you drag down while at the bottom of the page. This doesn't trigger a scroll, but shouldn't trigger a click.

The same for horizontal dragging (when used with swipe navigation), this also doesn't scroll.

Clooos added a commit that referenced this issue Nov 13, 2024
- [x] New more compact design for the climate card, this new design don’t use a sub-button for the temperature anymore. Important: If you’ve added climate cards before, just open these cards one by one in the editor, the previous temperature sub-button will be automatically deleted. Don’t forget to save after that.
- [x] Full support for climate entities with `target_temp_low` and `target_temp_high` #877
- [x] In heat_cool mode, the climate card color now change based on if it’s actually heating or cooling. #863
- [x] Actions are not triggered when scrolling anymore, finally! #892 and #839
- [x] Fixed an issue where it was impossible to scroll anymore in some cases (like in the editor).
- [x] Added the missing bubble-accent-color variable in the media player play/pause button.
- [x] Update climate specific css vars #908 PR from @flobiwankenobi
- [x] New element for pop-up background, breaking change for some users with custom styles. #895
- [x] Underscore removing from list select #890
- [x] Some pop-ups were not displayed displayed correctly, or only when leaving the editor/changing view, this is now fixed! #821
- [x] Fixed some more pop-up issues (like console errors). #840 and #791
- [x] Cover open and close buttons are now disabled when they should. #788
- [x] Slider for controlling thermostat/fan should now works correctly. #849, #838 and #768
@michaelarnauts
Copy link
Author

@Clooos beta5 fixed it for the vertical scrolling, but it still triggers a popup (or a click when the action is toggle) when doing a horizontal swipe (to move to the next page).

@Clooos
Copy link
Owner

Clooos commented Nov 13, 2024

Damn, I haven't covered the horizontal swipe indeed! 🫠

@Clooos
Copy link
Owner

Clooos commented Nov 14, 2024

@michaelarnauts I've just tried and I'm unable to reproduce it (at least on the Android HA app), can you tell me how to reproduce this?

@michaelarnauts
Copy link
Author

I have swipe navigation installed (https://github.com/zanna-37/hass-swipe-navigation) and configured.

Then, when you have multiple tabs in your dashboard, you can swipe left and right to move to another tab.

When doing this over a bubble cart button, the more info dialog pops up. It actually seems to trigger the click action causing the more info dialog to show.

@Clooos
Copy link
Owner

Clooos commented Nov 14, 2024

Do you had this issue before the v2.3.0 betas? Even if it was not the case before, I have developed a new system for the actions that is much more efficient and I'm not sure that I can do much since this issue seems to only happen in combination with swipe navigation.

But I'm probably wrong, it is just difficult for me to cover every cases just by myself, so if anyone want to contribute on this, he will be more than welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants
@michaelarnauts @sebster6 @Clooos @FalkPe @Tee86 @peterthepeter and others