Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CW-8641 FIX: Paginated data is not showing in # taged object #16

Merged
merged 1 commit into from
Apr 2, 2024
Merged

CW-8641 FIX: Paginated data is not showing in # taged object #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/ckeditor.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/ckeditor.js.map
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 0 additions & 6 deletions packages/ckeditor5-mention/src/mentionui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,6 @@ export default class MentionUI extends Plugin {
const mentionsView = new MentionsView(locale);
mentionsView.items.bindTo(this._items).using(data => {
const { item, marker } = data;
const { dropdownLimit: markerDropdownLimit } = this._mentionsConfigurations.get(marker);
// Set to 10 by default for backwards compatibility. See: #10479
const dropdownLimit = markerDropdownLimit || this.editor.config.get('mention.dropdownLimit') || 10;
if (mentionsView.items.length >= dropdownLimit) {
return null;
}
Comment on lines -151 to -156
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ckeditor/ckeditor5#10479

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

our old code

const listItemView = new MentionListItemView(locale);
const view = this._renderItem(item, marker);
view.delegate('execute').to(listItemView);
Expand Down