Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Rankscore as Float Type #122

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

torbjorgen
Copy link
Contributor

  • Add test case for checking RankScore is float in processed VCF
  • score_variant|compound: Provide RankScore as float type

Going forward, the expected behavior is that RankScore
is to be a float-type value in VCFs.

Signed-off-by: Tor Björgen <[email protected]>
@torbjorgen torbjorgen marked this pull request as ready for review December 1, 2023 14:35
@torbjorgen torbjorgen requested a review from jemten December 1, 2023 14:35
Copy link

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Don't know enough pytest to comment on it :)

@torbjorgen torbjorgen requested a review from dnil December 1, 2023 16:29
@torbjorgen
Copy link
Contributor Author

FYI @dnil

@torbjorgen torbjorgen merged commit abbbdb7 into master Dec 4, 2023
1 check passed
@torbjorgen torbjorgen deleted the rankscore-cast-to-float branch December 4, 2023 09:32
@torbjorgen torbjorgen linked an issue Dec 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixed int-float in RankScore
2 participants