Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional parameters for tomte #3112

Merged
merged 44 commits into from
Apr 25, 2024
Merged

Add conditional parameters for tomte #3112

merged 44 commits into from
Apr 25, 2024

Conversation

fevac
Copy link
Contributor

@fevac fevac commented Apr 12, 2024

Description

Added

  • Conditional parameters for tomte: gene panel, genome and tissue

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-servers-stage.sh tomte_conditional_config
    
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b tomte_update_params -a

How to test

  • cg workflow tomte config-case CASE.
    • Make sure it creates a gene panel file called gene_panels.bed that is not empty and formatted as expected

image

  • Make sure that _nextflow_config.json contains the following parameters set params.gene_panel_clinical_filter params.tissue params.genome

image

  • cg workflow tomte start CASE. Starts as expected without errors.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@fevac
Copy link
Contributor Author

fevac commented Apr 12, 2024

Pending to revise in a different PR:

  • get_aggregated_panels: has a weird behaviour. Make it clear and add documentation.
  • get source for external and downsampled cases

@fevac fevac self-assigned this Apr 12, 2024
@fevac fevac marked this pull request as ready for review April 12, 2024 12:44
@fevac fevac requested a review from a team as a code owner April 12, 2024 12:44
@diitaz93 diitaz93 self-requested a review April 15, 2024 11:38
@ivadym ivadym self-requested a review April 15, 2024 11:41
cg/apps/scout/scoutapi.py Show resolved Hide resolved
cg/constants/gene_panel.py Show resolved Hide resolved
cg/meta/workflow/nf_analysis.py Outdated Show resolved Hide resolved
cg/meta/workflow/analysis.py Outdated Show resolved Hide resolved
cg/meta/workflow/nf_analysis.py Show resolved Hide resolved
cg/meta/workflow/nf_analysis.py Show resolved Hide resolved
cg/meta/workflow/nf_analysis.py Outdated Show resolved Hide resolved
cg/meta/workflow/nf_analysis.py Outdated Show resolved Hide resolved
cg/meta/workflow/nf_analysis.py Outdated Show resolved Hide resolved
cg/meta/workflow/nf_analysis.py Outdated Show resolved Hide resolved
@ivadym ivadym mentioned this pull request Apr 18, 2024
18 tasks
@fevac fevac requested a review from diitaz93 April 24, 2024 12:55
cg/constants/constants.py Outdated Show resolved Hide resolved
cg/models/tomte/tomte.py Outdated Show resolved Hide resolved
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my concerns have been addressed 👍

cg/apps/lims/api.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more from my part, great job! 🏁 🏎️

Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fevac
Copy link
Contributor Author

fevac commented Apr 25, 2024

tests are passing

@fevac fevac merged commit 658b19d into master Apr 25, 2024
9 checks passed
@fevac fevac deleted the tomte_update_params branch April 25, 2024 12:07
@fevac
Copy link
Contributor Author

fevac commented Apr 25, 2024

Note

This branch as not been deployed in production due to issues with Hasta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants