Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mortality input file to be compatible with new format #74

Merged
merged 7 commits into from
Apr 6, 2023

Conversation

JMGilbert
Copy link
Contributor

@JMGilbert JMGilbert commented Feb 28, 2023

Change output of prep_mortality_damages to work with the new format of mortality valued projection system outputs.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #74 (9d59456) into dscim-v0.4.0 (e228c6e) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

❗ Current head 9d59456 differs from pull request most recent head 639d5f8. Consider uploading reports for the commit 639d5f8 to get more accurate results

@@               Coverage Diff                @@
##           dscim-v0.4.0      #74      +/-   ##
================================================
- Coverage         40.35%   40.11%   -0.24%     
================================================
  Files                18       17       -1     
  Lines              1846     1857      +11     
================================================
  Hits                745      745              
- Misses             1101     1112      +11     
Impacted Files Coverage Δ
src/dscim/preprocessing/input_damages.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JMGilbert JMGilbert marked this pull request as ready for review March 28, 2023 16:00
else:
raise ValueError("Mortality version not valid: ", str(mortality_version))

# We set 0 population to infinity so that per capita damages are 0 in locations with 0 population
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JMGilbert @davidrzhdu based on convo today it sounds like we should implement this for other sector inputs if we don't already

@kemccusker kemccusker merged commit 3d1242b into dscim-v0.4.0 Apr 6, 2023
@kemccusker kemccusker deleted the new_mortality_format branch April 6, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants