[chore] Fix a data race in the tests of healthcheckextension (open-te…

…lemetry#28629) Fixes open-telemetry#21401
ClickHouse · Nov 24, 2023 · 7ff2aae · 7ff2aae
1 parent 6259a56
commit 7ff2aae
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/extension/healthcheckextension/healthcheckextension_test.go b/extension/healthcheckextension/healthcheckextension_test.go
@@ -196,6 +196,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) {
 				},
 				{
 					step: func(hcExt *healthCheckExtension) error {
+						hcExt.exporter.mu.Lock()
+						defer hcExt.exporter.mu.Unlock()
 						hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData())
 						return hcExt.Ready()
 					},
@@ -207,6 +209,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) {
 				},
 				{
 					step: func(hcExt *healthCheckExtension) error {
+						hcExt.exporter.mu.Lock()
+						defer hcExt.exporter.mu.Unlock()
 						hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData())
 						return hcExt.Ready()
 					},
@@ -233,6 +237,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) {
 				},
 				{
 					step: func(hcExt *healthCheckExtension) error {
+						hcExt.exporter.mu.Lock()
+						defer hcExt.exporter.mu.Unlock()
 						hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData())
 						return hcExt.Ready()
 					},
@@ -244,6 +250,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) {
 				},
 				{
 					step: func(hcExt *healthCheckExtension) error {
+						hcExt.exporter.mu.Lock()
+						defer hcExt.exporter.mu.Unlock()
 						hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData())
 						return hcExt.Ready()
 					},
@@ -272,6 +280,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) {
 				},
 				{
 					step: func(hcExt *healthCheckExtension) error {
+						hcExt.exporter.mu.Lock()
+						defer hcExt.exporter.mu.Unlock()
 						hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData())
 						return hcExt.Ready()
 					},
@@ -285,6 +295,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) {
 				},
 				{
 					step: func(hcExt *healthCheckExtension) error {
+						hcExt.exporter.mu.Lock()
+						defer hcExt.exporter.mu.Unlock()
 						hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData())
 						return hcExt.Ready()
 					},