Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support range based dictionary layouts #361

Merged

Conversation

rjoelnorgren
Copy link
Contributor

@rjoelnorgren rjoelnorgren commented Sep 24, 2024

The range_hashed and complex_key_range_hashed dictionary layouts require a value is set for RANGE in the ddl. This PR checks the model config for the range key and sets one if provided by the materialization.

@BentsiLeviav
Copy link
Contributor

BentsiLeviav commented Oct 30, 2024

Hi @rjoelnorgren

Thank you for your contribution!
Before reviewing your PR, it is required to add a short description with a PR link to the changelog (please keep the current format we have in the Changelog file).
If possible, please add a test coverage for this.

@BentsiLeviav BentsiLeviav merged commit f5c00bb into ClickHouse:main Oct 30, 2024
@rjoelnorgren rjoelnorgren deleted the feat-add-range-layout-dictionary branch October 30, 2024 15:57
@rjoelnorgren
Copy link
Contributor Author

Hi @rjoelnorgren

Thank you for your contribution! Before reviewing your PR, it is required to add a short description with a PR link to the changelog (please keep the current format we have in the Changelog file). If possible, please add a test coverage for this.

@BentsiLeviav, thanks for merging despite being incomplete. Following up here #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants