feat: implement listagg macro #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BentsiLeviav
reviewed
Jun 8, 2024
| {% set arr = "array_agg({})".format(measure) %} | ||
| {% set arr = "arraySort({}, {})".format(arr, order_by_clause) if order_by_clause else arr %} | ||
| {% if limit_num -%} | ||
| arrayStringConcat('{{delimiter_text}}', arraySlice({{ arr }}, 1, {{ limit_num }})) |
There was a problem hiding this comment.
based on the docs it seems that you need to pass the column name/array first, and only then the delimiter.
There was a problem hiding this comment.
ah, thanks a lot!
There was a problem hiding this comment.
based on docs singlequote also not needed. fixed that too
BentsiLeviav
reviewed
Jun 9, 2024
Closed
|
I created a different task (#301) for adjusting the tests to assert the results. |
BentsiLeviav
added a commit
to BentsiLeviav/docs.getdbt.com
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement listagg macro, which is not supported at the moment