[client-v2] Fix reading binary streams #1759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem 1
Some streams return
0
whenavailable()
called even when data is available. Some streams may throw EOFException while read some may not. So only check for number of read bytes or result ofread()
really works.Problem 2
If we want to wrap a stream of data into collection we must properly implement
hasNext()
. Because of problem#1 we can not do it easilySolution
read()
result and throw EOFExceptionChecklist
Delete items not relevant to your PR: