Add retry on NoHttpResponseException #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chernser
changed the title
mzitnik
reviewed
Jul 7, 2024
| * <li>{@code 503 Service Unavailable}</li> | ||
| * </ul> | ||
| */ | ||
| AHC_RETRY_ON_FAILURE("ahc_retry_on_failure", false, "Whether to retry on failure with AsyncHttpClient.") |
There was a problem hiding this comment.
Can we change the name of the property?
There was a problem hiding this comment.
Yes, sure. But let me explain why I've chosen this one - implementation works only for Apache HC and only for old client.
In the new client I would name it http.retry_on_failure meaning it will be supported for every http implementation we ever have.
mzitnik
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a problem with keep-alive connection. Sometimes a server closes it and a client knows nothing about it. Causes of happening it are different and it is complex to resolve with a single strategy.
Apache HC throws
com.github.dockerjava.zerodep.shaded.org.apache.hc.core5.http.NoHttpResponseExceptionwhen request is sent over a "bad" connection. This PR will retry one more time immediately ifcom.clickhouse.client.http.config.ClickHouseHttpOption#AHC_RETRY_ON_FAILUREis enabled.However not every request may be retried safely. And here is another problem - it is extremely hard to detect what request is safe to retry. For example, it depends on if data stream is resettable in case of write operation.
Checklist
Delete items not relevant to your PR: