Refactored metrics to make them more generic #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzitnik
requested changes
Jun 6, 2024
| System.out.println("Server read rows: " + metrics.getMetric(ServerMetrics.NUM_ROWS_READ).getLong()); | ||
| System.out.println("Client stats: " + metrics.getMetric(ClientMetrics.OP_DURATION).getLong()); | ||
|
|
||
| Assert.assertEquals(metrics.getMetric(ServerMetrics.NUM_ROWS_READ).getLong(), rowsToInsert); // 10 rows in the table |
There was a problem hiding this comment.
We discuss to have getter methods (explicit) in this case, i need metrics.getMetric(ServerMetrics.NUM_ROWS_READ).getLong()) why not just metric.getNumRowsRead() return long
There was a problem hiding this comment.
There are going to be many metrics over time. Getting only few of them is not a major usecase.
I think users will have list of metrics what they want to publish to some metrics storage - so such getter is more useful than getter for each metric.
mzitnik
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously there was server stats as primitive field. It was done to reduce memory footprint. But as any early optimization it cause need to make some changes. So metrics became a map of different values and anyone may read them all from operation in a simple over-map-entries loop.