Set X-ClickHouse-Format HTTP response header to the format name #8769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
Detailed description / Documentation draft:
From now on, HTTP responses will have
X-ClickHouse-Format
header set to the format name of the returned data.executeQuery()
callbackset_content_type
is renamed toset_content_type_and_format
that is expected to accept 2 string arguments: content-type (as before), and format (added).Motivation: ODBC driver can only set the default format, and has now way of reliably determining the actual format of the response (which could be modified by in-SQL
FORMAT
keyword), thus unable to parse, or even detect an unsupported response data format in general case.