Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reloading storage configuration from configuration file #8594

Merged
merged 3 commits into from
Mar 5, 2020
Merged

Added reloading storage configuration from configuration file #8594

merged 3 commits into from
Mar 5, 2020

Conversation

excitoon
Copy link
Contributor

@excitoon excitoon commented Jan 9, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • New Feature

Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):

Added reloading storage configuration from configuration file.

@excitoon excitoon changed the title Added reloading storage configuration from configuration file. Added reloading storage configuration from configuration file Jan 9, 2020
@nvartolomei
Copy link
Contributor

This is exciting. Can you share more about the intention here and what use cases you want to support? Ie. will it be possible to just remove a disk and ClickHouse will run part checks/repair for replicated tables and missing parts?

@alexey-milovidov
Copy link
Member

@excitoon Any updates?

@nvartolomei

Ie. will it be possible to just remove a disk and ClickHouse will run part checks/repair for replicated tables and missing parts?

If parts are not available or not readable, ClickHouse will download them from replicas. Removing a disk and removing it from the configuration will work.

@alexey-milovidov
Copy link
Member

boost::shared_ptr - looks strange.
Is the assignment operator atomic by default (it's unlikely)?
Why don't use MultiVersion as discussed?

@alexey-milovidov
Copy link
Member

(rebased but boost::shared_ptr remains)

@excitoon
Copy link
Contributor Author

excitoon commented Mar 4, 2020

@alexey-milovidov I did not use MultiVersion because shared_ptr looks simpler thing to me.

@alexey-milovidov alexey-milovidov merged commit e68d31d into ClickHouse:master Mar 5, 2020
@BayoNet
Copy link
Contributor

BayoNet commented Mar 6, 2020

@excitoon
Hello.
Could you explain how to use it?
Update storage config first and call SYSTEM UPDATE CONFIG then?
Are there some tricky things?

@alexey-milovidov
Copy link
Member

alexey-milovidov commented Mar 6, 2020

@BayoNet The configuration will be updated automatically when user has changed the config file.

@KochetovNicolai KochetovNicolai added the pr-feature Pull request with new product feature label Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants