-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable DwarfFDECache in libunwind #7838
Merged
alexey-milovidov
merged 2 commits into
ClickHouse:master
from
filimonov:issue7383_update_libunwind
Nov 20, 2019
Merged
Disable DwarfFDECache in libunwind #7838
alexey-milovidov
merged 2 commits into
ClickHouse:master
from
filimonov:issue7383_update_libunwind
Nov 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc-9 failure - looks the same as #7114 It seems like the reason is pthread is not linked into protoc directly, and That dirty hack fixes the gcc-9 build: diff --git a/cmake/protoc.cmake b/cmake/protoc.cmake
index 5777b16..49aa106 100644
--- a/cmake/protoc.cmake
+++ b/cmake/protoc.cmake
@@ -3,5 +3,5 @@ set(protoc_files
)
add_executable(protoc ${protoc_files})
-target_link_libraries(protoc libprotobuf libprotoc)
+target_link_libraries(protoc libprotobuf libprotoc pthread)
add_executable(protobuf::protoc ALIAS protoc) Unused var warning fixed here: Those things:
existed already in master: |
tavplubix
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Nov 21, 2019
tavplubix
pushed a commit
that referenced
this pull request
Nov 21, 2019
Disable DwarfFDECache in libunwind
tavplubix
pushed a commit
that referenced
this pull request
Nov 21, 2019
Disable DwarfFDECache in libunwind
tavplubix
pushed a commit
that referenced
this pull request
Nov 21, 2019
Disable DwarfFDECache in libunwind
vitlibar
pushed a commit
that referenced
this pull request
Dec 26, 2019
Disable DwarfFDECache in libunwind (cherry picked from commit 9b25e47)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Fix rare deadlock which can happen when trace_log is in enabled.
Detailed description (optional):
Fixes #7383
See details in ClickHouse/libunwind#1
I was not able to reproduce the issue in any synthetic case, it happened on production cluster 3 times during a month.
P.S. kudos to @laplab for the help.