-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command-line arguments with no value that are Bool settings should be implicitly set to true. #70459
Conversation
This is an automated comment for commit a576fc3 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
# shellcheck source=../shell_config.sh | ||
. "$CUR_DIR"/../shell_config.sh | ||
|
||
$CLICKHOUSE_CLIENT --optimize_aggregation_in_order --query "SELECT 1" 2>&1 | grep -q "1" && echo "OK" || echo "FAIL" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do SELECT value FROM system.settings WHERE name = 'optimize_aggregation_in_order'
instead just selecting 1
options.add(boost::shared_ptr<boost::program_options::option_description>(new boost::program_options::option_description( | ||
name.data(), boost::program_options::value<Strings>()->multitoken()->composing()->notifier(on_program_option), field.getDescription()))); | ||
if (field.getTypeName() == "Bool") | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that l. 16/17 and l. 21/22 are almost the same, a brief comment could have been useful.
@@ -0,0 +1,9 @@ | |||
#!/usr/bin/env bash | |||
# Tags: no-fasttest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, why is this marked no-fasttest
?
Closes #70291
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Command-line arguments for Bool settings are set to true when no value is provided for the argument (e.g.
clickhouse-client --optimize_aggregation_in_order --query "SELECT 1"
).Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):