-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove constants from StorageMerge header in Complete stage #67146
Merged
KochetovNicolai
merged 2 commits into
master
from
fix-constants-in-merge-over-distr-single-shard
Jul 29, 2024
Merged
Remove constants from StorageMerge header in Complete stage #67146
KochetovNicolai
merged 2 commits into
master
from
fix-constants-in-merge-over-distr-single-shard
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KochetovNicolai
added
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
analyzer
Issues and pull-requests related to new analyzer
labels
Jul 25, 2024
robot-ch-test-poll3
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Jul 25, 2024
Contributor
This is an automated comment for commit 8d13461 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
KochetovNicolai
changed the title
Do not remove constants from Distributed header in Complete stage
Remove constants from StorageMerge header in Complete stage
Jul 26, 2024
novikd
approved these changes
Jul 26, 2024
KochetovNicolai
deleted the
fix-constants-in-merge-over-distr-single-shard
branch
July 29, 2024 12:22
robot-ch-test-poll1
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Jul 29, 2024
This was referenced Jul 29, 2024
This was referenced Jul 29, 2024
This was referenced Jul 29, 2024
This was referenced Jul 29, 2024
This was referenced Jul 29, 2024
robot-clickhouse-ci-2
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Jul 29, 2024
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
Jul 29, 2024
Backport #67146 to 24.6: Remove constants from StorageMerge header in Complete stage
robot-ch-test-poll2
added a commit
that referenced
this pull request
Jul 29, 2024
Backport #67146 to 24.4: Remove constants from StorageMerge header in Complete stage
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Jul 29, 2024
Backport #67146 to 24.5: Remove constants from StorageMerge header in Complete stage
robot-ch-test-poll2
added a commit
that referenced
this pull request
Jul 29, 2024
Backport #67146 to 24.3: Remove constants from StorageMerge header in Complete stage
robot-ch-test-poll3
added a commit
that referenced
this pull request
Jul 30, 2024
Backport #67146 to 24.7: Remove constants from StorageMerge header in Complete stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
analyzer
Issues and pull-requests related to new analyzer
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix error
Cannot convert column because it is non constant in source stream but must be constant in result.
for a query that reads from theMerge
table over theDistriburted
table with one shard.Fixes #66565
CI Settings (Only check the boxes if you know what you are doing):