Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ON CLUSTER clause in queries for management of replicated named collections. #66288

Merged

Conversation

MikhailBurdukov
Copy link
Contributor

Add settings to ignore ON CLUSTER clause in queries for named collection management with replicated storage.
It is necessary for seamless migration of the existing codebase to replicated storage without changing current SQL queries.

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add settings to ignore ON CLUSTER clause in queries for named collection management with replicated storage.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Jul 9, 2024
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Jul 9, 2024

This is an automated comment for commit 743fccb with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@den-crane
Copy link
Contributor

this is kinda inconsistent with other entities

CREATE USER dfsdfsdfsd ON CLUSTER segmented

Query id: 66a80520-58af-4049-af84-ec42d686e059

Connecting to localhost:9000 as user default.
Connected to ClickHouse server version 24.3.4.

   ┌─host────────────────────────┬─port─┬─status─┬─error─┬─num_hosts_remaining─┬─num_hosts_active─┐
1. │ chdw1-1.sde10190.mycmdb.net │ 9000 │      0 │       │                   1 │                0 │
   └─────────────────────────────┴──────┴────────┴───────┴─────────────────────┴──────────────────┘
   ┌─host────────────────────────┬─port─┬─status─┬─error───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┬─num_hosts_remaining─┬─num_hosts_active─┐
2. │ chdw1-1.sde10186.mycmdb.net │ 9000 │    493 │ Code: 493. DB::Exception: user `dfsdfsdfsd`: cannot insert because user `dfsdfsdfsd` already exists in replicated. (ACCESS_ENTITY_ALREADY_EXISTS) (version 24.3.4.147 (official build)) │                   0 │                0 │
   └─────────────────────────────┴──────┴────────┴─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┴─────────────────────┴──────────────────┘

@kssenii kssenii self-assigned this Jul 9, 2024
@MikhailBurdukov
Copy link
Contributor Author

this is kinda inconsistent with other entities

CREATE USER dfsdfsdfsd ON CLUSTER segmented

Query id: 66a80520-58af-4049-af84-ec42d686e059

Connecting to localhost:9000 as user default.
Connected to ClickHouse server version 24.3.4.

   ┌─host────────────────────────┬─port─┬─status─┬─error─┬─num_hosts_remaining─┬─num_hosts_active─┐
1. │ chdw1-1.sde10190.mycmdb.net │ 9000 │      0 │       │                   1 │                0 │
   └─────────────────────────────┴──────┴────────┴───────┴─────────────────────┴──────────────────┘
   ┌─host────────────────────────┬─port─┬─status─┬─error───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┬─num_hosts_remaining─┬─num_hosts_active─┐
2. │ chdw1-1.sde10186.mycmdb.net │ 9000 │    493 │ Code: 493. DB::Exception: user `dfsdfsdfsd`: cannot insert because user `dfsdfsdfsd` already exists in replicated. (ACCESS_ENTITY_ALREADY_EXISTS) (version 24.3.4.147 (official build)) │                   0 │                0 │
   └─────────────────────────────┴──────┴────────┴─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┴─────────────────────┴──────────────────┘

AFAIK it is expected behaviour. For ignoring ON CLUSTER in access entities management queries you should use ignore_on_cluster_for_replicated_access_entities_queries opt. It's disabled by default.

@MikhailBurdukov
Copy link
Contributor Author

Failed tests seems unrelated, can we merge? @kssenii

@kssenii
Copy link
Member

kssenii commented Jul 11, 2024

AST fuzzer (ubsan)

#64945

@kssenii kssenii added this pull request to the merge queue Jul 11, 2024
Merged via the queue into ClickHouse:master with commit c23aa2b Jul 11, 2024
196 of 205 checks passed
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants