Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore allow_suspicious_primary_key on ATTACH and verify on ALTER #64202

Merged

Conversation

azat
Copy link
Collaborator

@azat azat commented May 21, 2024

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Ignore allow_suspicious_primary_key on ATTACH and verify on ALTER

Follow-up for: #61399 (cc @tavplubix )

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-improvement Pull request with some product improvements label May 21, 2024
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented May 21, 2024

This is an automated comment for commit 8dd52a2 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@nikitamikhaylov
Copy link
Member

We should also ignore it for secondary CREATE queries (which are coming from the DDL queue).

@tavplubix tavplubix self-assigned this May 21, 2024
src/Storages/MergeTree/registerStorageMergeTree.cpp Outdated Show resolved Hide resolved
src/Storages/MergeTree/registerStorageMergeTree.cpp Outdated Show resolved Hide resolved
Signed-off-by: Azat Khuzhin <[email protected]>
Co-authored-by: Alexander Tokmakov <[email protected]>
@azat azat force-pushed the allow_suspicious_primary_key-fixes branch from d9872d8 to 8dd52a2 Compare May 22, 2024 10:54
@azat
Copy link
Collaborator Author

azat commented May 22, 2024

@tavplubix I've rebased on top of the #64204 (to fix build failures) and I squashed your commits (but added co-authored tag).

@tavplubix tavplubix enabled auto-merge May 22, 2024 21:55
@tavplubix tavplubix added this pull request to the merge queue May 22, 2024
Merged via the queue into ClickHouse:master with commit cd1d6d9 May 22, 2024
228 of 235 checks passed
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 23, 2024
@azat azat deleted the allow_suspicious_primary_key-fixes branch May 23, 2024 05:39
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Oct 9, 2024
…y_key-fixes

Ignore allow_suspicious_primary_key on ATTACH and verify on ALTER
Enmk added a commit to Altinity/ClickHouse that referenced this pull request Oct 10, 2024
…ow_suspicious_primary_key_on_attach

24.3 Backport of ClickHouse#64202 - Ignore allow_suspicious_primary_key on ATTACH and verify on ALTER
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants