-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore allow_suspicious_primary_key on ATTACH and verify on ALTER #64202
Merged
tavplubix
merged 1 commit into
ClickHouse:master
from
azat:allow_suspicious_primary_key-fixes
May 22, 2024
Merged
Ignore allow_suspicious_primary_key on ATTACH and verify on ALTER #64202
tavplubix
merged 1 commit into
ClickHouse:master
from
azat:allow_suspicious_primary_key-fixes
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-1
added
the
pr-improvement
Pull request with some product improvements
label
May 21, 2024
Contributor
This is an automated comment for commit 8dd52a2 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
We should also ignore it for secondary CREATE queries (which are coming from the DDL queue). |
tavplubix
approved these changes
May 21, 2024
30 tasks
Signed-off-by: Azat Khuzhin <[email protected]> Co-authored-by: Alexander Tokmakov <[email protected]>
azat
force-pushed
the
allow_suspicious_primary_key-fixes
branch
from
May 22, 2024 10:54
d9872d8
to
8dd52a2
Compare
@tavplubix I've rebased on top of the #64204 (to fix build failures) and I squashed your commits (but added co-authored tag). |
Merged
via the queue into
ClickHouse:master
with commit May 22, 2024
cd1d6d9
228 of 235 checks passed
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
May 23, 2024
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Oct 9, 2024
…y_key-fixes Ignore allow_suspicious_primary_key on ATTACH and verify on ALTER
Enmk
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Oct 10, 2024
…ow_suspicious_primary_key_on_attach 24.3 Backport of ClickHouse#64202 - Ignore allow_suspicious_primary_key on ATTACH and verify on ALTER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-improvement
Pull request with some product improvements
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Ignore
allow_suspicious_primary_key
onATTACH
and verify onALTER
Follow-up for: #61399 (cc @tavplubix )