-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics to plain_rewritable
metadata storage
#64175
Merged
jkartseva
merged 5 commits into
ClickHouse:master
from
jkartseva:add-metrics-to-plain-rw
May 29, 2024
Merged
Add metrics to plain_rewritable
metadata storage
#64175
jkartseva
merged 5 commits into
ClickHouse:master
from
jkartseva:add-metrics-to-plain-rw
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll4
added
the
pr-improvement
Pull request with some product improvements
label
May 21, 2024
Contributor
This is an automated comment for commit a0f18eb with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
jkartseva
added
the
can be tested
Allows running workflows for external contributors
label
May 21, 2024
jkartseva
force-pushed
the
add-metrics-to-plain-rw
branch
from
May 21, 2024 06:18
6db70ca
to
d0d140e
Compare
antonio2368
reviewed
May 21, 2024
jkartseva
force-pushed
the
add-metrics-to-plain-rw
branch
from
May 21, 2024 20:19
d0d140e
to
fab2375
Compare
30 tasks
antonio2368
approved these changes
May 22, 2024
Builds are fixed in master. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
May 22, 2024
jkartseva
force-pushed
the
add-metrics-to-plain-rw
branch
2 times, most recently
from
May 22, 2024 20:26
f8e3ad6
to
b93f1dd
Compare
jkartseva
force-pushed
the
add-metrics-to-plain-rw
branch
from
May 23, 2024 03:12
62b9282
to
ce1d630
Compare
jkartseva
force-pushed
the
add-metrics-to-plain-rw
branch
3 times, most recently
from
May 25, 2024 01:49
5b0d42c
to
b0eb7f2
Compare
Metrics to track the number of directories created and removed by the plain_rewritable metadata storage, and the number of entries in the local-to-remote in-memory map.
jkartseva
force-pushed
the
add-metrics-to-plain-rw
branch
from
May 28, 2024 19:02
b0eb7f2
to
a0f18eb
Compare
Merged
via the queue into
ClickHouse:master
with commit May 29, 2024
c6dda82
236 of 249 checks passed
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
May 29, 2024
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-improvement
Pull request with some product improvements
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add metrics to track the number of directories created and removed by the plain_rewritable metadata storage, and the number of entries in the local-to-remote in-memory map.
Documentation entry for user-facing changes
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: