-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SimpleSquashingChunksTransform #62451
Merged
nickitat
merged 3 commits into
ClickHouse:master
from
nickitat:fix_simple_squashing_transform
Apr 12, 2024
Merged
Fix SimpleSquashingChunksTransform #62451
nickitat
merged 3 commits into
ClickHouse:master
from
nickitat:fix_simple_squashing_transform
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
robot-ch-test-poll
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Apr 9, 2024
Contributor
This is an automated comment for commit 8b38fab with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
devcrafter
reviewed
Apr 9, 2024
devcrafter
reviewed
Apr 10, 2024
nickitat
force-pushed
the
fix_simple_squashing_transform
branch
from
April 11, 2024 12:36
14caa91
to
8b38fab
Compare
devcrafter
approved these changes
Apr 11, 2024
Merged
via the queue into
ClickHouse:master
with commit Apr 12, 2024
cab7e76
228 of 236 checks passed
robot-ch-test-poll
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-bugfix
Pull request with bugfix, not backported by default
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed rare bug in
SimpleSquashingChunksTransform
that may lead to a loss of the last chunk of data in a stream.Analyzer became a victim, because it puts
SimpleSquashingChunksTransform
beforeMemorySink
when collecting data into a temp table.Fixes: #62173 #62192