-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ALTER MODIFY SETTING for Memory tables #62039
Merged
yariks5s
merged 8 commits into
ClickHouse:master
from
zhongyuankai:memory_table_modify_setting
Apr 10, 2024
Merged
Support ALTER MODIFY SETTING for Memory tables #62039
yariks5s
merged 8 commits into
ClickHouse:master
from
zhongyuankai:memory_table_modify_setting
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yariks5s
added
the
can be tested
Allows running workflows for external contributors
label
Mar 28, 2024
Contributor
This is an automated comment for commit 6277deb with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
yariks5s
reviewed
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting to add some cases in tests:
- when initially we have
max_bytes_to_keep
/max_rows_to_keep
= x and we setmax_bytes_to_keep
/max_rows_to_keep
= y, y < x. Good to check if everything is working right and we have a smaller circular buffer. - when initially we have a memory table with no settings and we apply these settings to this table.
- when initially we don't have
min_bytes_to_keep
/min_rows_to_keep
settings for the table and add them withALTER
. Also good to check if min settings are changed correctly - when we try to set incorrect values for those settings
zhongyuankai
force-pushed
the
memory_table_modify_setting
branch
from
April 1, 2024 03:55
6c1118f
to
9b1b81d
Compare
Related tests have been added. |
yariks5s
reviewed
Apr 3, 2024
tests/queries/0_stateless/03032_storage_memory_modify_settings.sql
Outdated
Show resolved
Hide resolved
zhongyuankai
force-pushed
the
memory_table_modify_setting
branch
from
April 6, 2024 12:39
1f6ff51
to
9e5f5f0
Compare
zhongyuankai
force-pushed
the
memory_table_modify_setting
branch
from
April 6, 2024 12:42
9e5f5f0
to
2573fb6
Compare
yariks5s
approved these changes
Apr 8, 2024
Merged
via the queue into
ClickHouse:master
with commit Apr 10, 2024
957c58c
227 of 234 checks passed
robot-ch-test-poll
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-feature
Pull request with new product feature
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #61922
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Modifying memory table settings through
ALTER MODIFY SETTING
is now supported.Documentation entry for user-facing changes
Modify your CI run:
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: