-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent setting custom metadata headers on unsupported multipart upload operations #60748
Merged
CheSema
merged 3 commits into
ClickHouse:master
from
Beetelbrox:fjurado/dont-add-metadata-headers-to-unsupported-multipart-steps
Mar 4, 2024
Merged
Prevent setting custom metadata headers on unsupported multipart upload operations #60748
CheSema
merged 3 commits into
ClickHouse:master
from
Beetelbrox:fjurado/dont-add-metadata-headers-to-unsupported-multipart-steps
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beetelbrox
changed the title
Do not send metadata headers on unsupported multipart upload operations
Prevent setting custom metadata headers on unsupported multipart upload operations
Mar 4, 2024
antaljanosbenjamin
added
the
can be tested
Allows running workflows for external contributors
label
Mar 4, 2024
robot-clickhouse-ci-2
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Mar 4, 2024
Contributor
This is an automated comment for commit e8f4e4e with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
CheSema
approved these changes
Mar 4, 2024
robot-ch-test-poll4
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Mar 4, 2024
@CheSema Would it be possible to backport this? We have features that depends on this fix and we're blocked until the next CH release to release them. Thanks! |
CheSema
added
pr-backport
Changes, backported to release branch. Do not use manually - automated use only!
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
and removed
pr-backport
Changes, backported to release branch. Do not use manually - automated use only!
labels
Mar 4, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Mar 4, 2024
…nsupported multipart upload operations
robot-clickhouse
added a commit
that referenced
this pull request
Mar 4, 2024
…unsupported multipart upload operations
robot-clickhouse
added a commit
that referenced
this pull request
Mar 4, 2024
…nsupported multipart upload operations
robot-clickhouse
added a commit
that referenced
this pull request
Mar 4, 2024
…nsupported multipart upload operations
robot-clickhouse-ci-1
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Mar 4, 2024
alexey-milovidov
added a commit
that referenced
this pull request
Mar 5, 2024
Backport #60748 to 24.2: Prevent setting custom metadata headers on unsupported multipart upload operations
alexey-milovidov
added a commit
that referenced
this pull request
Mar 5, 2024
Backport #60748 to 24.1: Prevent setting custom metadata headers on unsupported multipart upload operations
alexey-milovidov
added a commit
that referenced
this pull request
Mar 5, 2024
Backport #60748 to 23.12: Prevent setting custom metadata headers on unsupported multipart upload operations
Beetelbrox
deleted the
fjurado/dont-add-metadata-headers-to-unsupported-multipart-steps
branch
April 3, 2024 07:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Do not set aws custom metadata
x-amz-meta-*
headers on UploadPart & CompleteMultipartUpload callsFixes #60747
Both UploadPart and CompleteMultipartUpload don't accept custom metadata header so we simply drop them if we attept to add them to the request.
This error only happens when running agains S3 proper and I have no idea how to test it in the CI, as far as I can tell relies on MinIO. Any help on this would be much appreciated.