Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toDecimalString function #52520

Conversation

zvonand
Copy link
Contributor

@zvonand zvonand commented Jul 24, 2023

Fix toDecimalString, fix #52407

Reverts #52450

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@nikitamikhaylov
Copy link
Member

Why this function is better than something like this toString(toDecimal(x)) ?

@den-crane
Copy link
Contributor

den-crane commented Jul 24, 2023

@nikitamikhaylov

SELECT toDecimalString(toDecimal64(6, 6), 6);
┌─toDecimalString(toDecimal64(6, 6), 6)─┐
│ 6.000000                              │
└───────────────────────────────────────┘

SELECT toString(toDecimal64(6, 6));
┌─toString(toDecimal64(6, 6))─┐
│ 6                           │
└─────────────────────────────┘

see

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Jul 25, 2023
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Jul 25, 2023

This is an automated comment for commit 4f7bdf3 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 25, 2023
@zvonand zvonand marked this pull request as ready for review July 25, 2023 10:25
@zvonand zvonand mentioned this pull request Jul 25, 2023
@yakov-olkhovskiy yakov-olkhovskiy self-assigned this Jul 26, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 merged commit 7bcef0a into ClickHouse:master Jul 26, 2023
156 checks passed
@zvonand zvonand deleted the revert-52450-remove-to-decimal-string branch July 27, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClickHouse Server 23.7.1.1659 crashed through a SELECT statement calling the toDecimalString function
7 participants