Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark QPL_DEFLATE non-experimental but default: off-by-default #50775

Merged
merged 23 commits into from
Jun 21, 2023

Conversation

rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Jun 9, 2023

Continuation of #50305, courtesy of @jinjunzh

  • Codec DEFLATE_QPL is now controlled via setting "enable_qpl_deflate" (default: off) instead of setting "allow_experimental_codecs". This marks QPL_DEFLATE non-experimental.
  • Show ENABLE_QPL in system.build_options

Just including the first point in the change log as it's the important one for users.

Note to myself: Disable in CH cloud via constraint:

  <profiles>
        <default>
            <enable_deflate_qpl_codec>0</enable_deflate_qpl_codec>
            <constraints>
                <enable_deflate_qpl_codec>
                    <readonly/>
                </enable_deflate_qpl_codec>
            </constraints>
        </default>
    </profiles>

or

profiles:
  default:
    enable_deflate_qpl_codec: 0
    constraints:
      enable_deflate_qpl_codec:
        readonly: 1

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Codec DEFLATE_QPL is now controlled via server setting "enable_deflate_qpl_codec" (default: false) instead of setting "allow_experimental_codecs". This marks QPL_DEFLATE non-experimental.

@rschu1ze rschu1ze added the do not test disable testing on pull request label Jun 9, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Jun 9, 2023

This is an automated comment for commit bc7df2b with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 error

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🔴 error
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@rschu1ze rschu1ze force-pushed the non-experimental-qpl-deflate branch from 4411fc1 to 1aa1589 Compare June 9, 2023 12:43
@rschu1ze rschu1ze changed the title (wip) Control QPL_DEFLATE by its own cfg flag (default: off) + improve test coverage Mark QPL_DEFLATE non-experimental but default: off-by-default + improve test coverage Jun 9, 2023
@clickhouse-ci
Copy link

clickhouse-ci bot commented Jun 9, 2023

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog category is empty

@rschu1ze rschu1ze marked this pull request as ready for review June 9, 2023 20:55
@rschu1ze rschu1ze removed the do not test disable testing on pull request label Jun 9, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-feature Pull request with new product feature label Jun 9, 2023
@rschu1ze rschu1ze changed the title Mark QPL_DEFLATE non-experimental but default: off-by-default + improve test coverage Mark QPL_DEFLATE non-experimental but default: off-by-default Jun 11, 2023
@rschu1ze

This comment was marked as outdated.

@jinjunzh

This comment was marked as outdated.

@rschu1ze

This comment was marked as outdated.

@jinjunzh

This comment was marked as outdated.

@jinjunzh

This comment was marked as outdated.

@rschu1ze

This comment was marked as outdated.

@jinjunzh

This comment was marked as outdated.

@rschu1ze
Copy link
Member Author

rschu1ze commented Jun 21, 2023

ClickHouse Stateless Tests (ubsan) [2/2]:

ClickHouse Stateless Tests (debug, S3 Storage) [1/6]:

ClickHouse Stateless Tests (aarch64):

ClickHouse performance comparison:

  • SIZES_OF_ARRAYS_DONT_MATCH unrelated

ClickHouse Integration Tests (tsan) [1/6]

  • test_alter_moving_garbage/test.py::test_create_table[False-False] flaky since some days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants