-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow some settings for MySQL compatibility #50013
Conversation
@@ -98,9 +98,9 @@ DynamicResourceManager::State::Resource::~Resource() | |||
if (attached_to != nullptr) | |||
{ | |||
ISchedulerNode * root = nodes.find("/")->second.ptr.get(); | |||
attached_to->event_queue->enqueue([scheduler = attached_to, root] | |||
attached_to->event_queue->enqueue([my_scheduler = attached_to, root] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clang-17.
This is an automated comment for commit 4dbe5b8 with description of existing statuses. It's updated for the latest CI running
|
@@ -1,4 +1,4 @@ | |||
<clickhouse> | |||
<!-- Comma-separated list of prefixes for user-defined settings. --> | |||
<custom_settings_prefixes>custom_</custom_settings_prefixes> | |||
<custom_settings_prefixes>SQL_,custom_</custom_settings_prefixes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, we use our own mini-language (comma-separated values) inside XML.
The right way would be:
<custom_settings_prefixes>
<prefix>SQL_</prefix>
<prefix>custom_</prefix>
</custom_settings_prefixes>
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The server will allow using the
SQL_*
settings such asSQL_AUTO_IS_NULL
as no-ops for MySQL compatibility. This closes #49927.