-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix ODR for Loggers class #41060
Conversation
@nicelulu @Lucky-Chang does it help you? |
I propose not use current way to build mini-clickhouse-keeper. WITH_TEXT_LOG changes Loggers class declare, so encountered the ODR problem. it put things in a mess. Maybe we can introduce a lambda function hook to Loggers, it's better to solve the problem |
this pr not fix the problem |
The problem remains. |
After last changes everything works fine on my mac.
@Lucky-Chang keeper build script is okay, it just required to prorogate information, that we don't need text log. |
Builds ok, no failures. |
Unrelated |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Continuation of #40938. Fix ODR violation for
Loggers
class.Fixes #40398, #40937
cc @nicelulu @Lucky-Chang