Add setting to disable limit on kafka_num_consumers #40670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesapin
approved these changes
Aug 28, 2022
alesapin
added
the
pr-must-backport
This was referenced Aug 31, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 31, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 31, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 31, 2022
Avogar
added a commit
that referenced
this pull request
Sep 1, 2022
Backport #40670 to 22.8: Add setting to disable limit on kafka_num_consumers
Avogar
added a commit
that referenced
this pull request
Sep 1, 2022
Backport #40670 to 22.7: Add setting to disable limit on kafka_num_consumers
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 1, 2022
robot-clickhouse
added
the
pr-backports-created
Avogar
added a commit
that referenced
this pull request
Sep 1, 2022
Backport #40670 to 22.6: Add setting to disable limit on kafka_num_consumers
Avogar
added a commit
that referenced
this pull request
Sep 8, 2022
Backport #40670 to 22.3: Add setting to disable limit on kafka_num_consumers
azat
reviewed
Oct 25, 2022
| @@ -532,6 +532,7 @@ static constexpr UInt64 operator""_GiB(unsigned long long value) | |||
| M(UInt64, max_entries_for_hash_table_stats, 10'000, "How many entries hash table statistics collected during aggregation is allowed to have", 0) \ | |||
| M(UInt64, max_size_to_preallocate_for_aggregation, 10'000'000, "For how many elements it is allowed to preallocate space in all hash tables in total before aggregation", 0) \ | |||
| \ | |||
| M(Bool, kafka_disable_num_consumers_limit, false, "Disable limit on kafka_num_consumers that depends on the number of available CPU cores", 0) \ | |||
There was a problem hiding this comment.
Does it worth to add an extra setting just for this? Maybe simply log a message with error or similar severity is enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add setting to disable limit on kafka_num_consumers. Closes #40331